Fix egui on testbed#1
Merged
lukasfri merged 1 commit intolukasfri:masterfrom Oct 8, 2025
Merged
Conversation
Owner
|
@ThierryBerger Thanks! Yeah I haven't dipped into a lot of open source contributing, mainly working on my own stuff so don't know the ins and outs of what people expect from general contributions, thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After testing your PR locally, I realized testbeds were broken so I fixed it.
I can't push on you master as it seems you disallowed it.
As you mentioned you were a "beginner", I'll offer additional feedbacks: