Skip to content

Allow treetable to prepend nodes instead of appending#209

Open
Nejaa wants to merge 4 commits intoludo:masterfrom
Nejaa:master
Open

Allow treetable to prepend nodes instead of appending#209
Nejaa wants to merge 4 commits intoludo:masterfrom
Nejaa:master

Conversation

@Nejaa
Copy link
Copy Markdown

@Nejaa Nejaa commented Nov 16, 2017

This PR aim to expand the feature of the treetable to allow it to prepend nodes on demand.

A new parameter prependRootNodes, by default false, added to the settings allow to set this behavior globally but only to root nodes (if needed I'll expand again to add a global param for this behavior on non root nodes).

A new parameter on the loadBranch function called prepend will allow to specifically request this current call to loadBranch to prepend nodes instead of appending them.

In any case it is still required from the user to provide the tr elements sorted if they pass several at once. It was not my intention to reverse the rows if multiples rows are passed at once.
For instance prepending:

-1.3
-1.4
-1.5

to:

1
-1.1
-1.2

with only one call to loadBranch will produce:

1
-1.3
-1.4
-1.5
-1.1
-1.2

@Nejaa
Copy link
Copy Markdown
Author

Nejaa commented Nov 16, 2017

Last commit fixing side effects I did not see comming. It seems to pass my tests now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant