Performance problem with rendering a treetable in an iframe (IE11)#173
Open
benSn wants to merge 2 commits intoludo:masterfrom
Open
Performance problem with rendering a treetable in an iframe (IE11)#173benSn wants to merge 2 commits intoludo:masterfrom
benSn wants to merge 2 commits intoludo:masterfrom
Conversation
According to this Tweet from Paul Irish: https://twitter.com/paul_irish/status/564443848613847040 you shouldn't use jQuery's hide() method.
Performance recommendation: Do not use jQuery's hide() method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across this issue when testing a large collapsible treetable (over 2000 entries) rendered in an iframe in the IE11. The treetable renders ok in a standalone page (about 2 seconds) but in an IE11 iframe it took more than 50 seconds. After profiling the whole thing, the problem seemed to be related with jQuery hide method.
The change from .hide() to .css('display','none') fixed the performance issue.