Open
Conversation
Author
|
Is there anything I need to do? Or can this pr be merged? c: |
|
When this PR is reviewed, I will roll back this change. |
- Update allay-api dependency from 0.17.0-SNAPSHOT to 0.17.0 - Refactor AllayCommandSender to use new API methods: * Replace instanceof check with isPlayer() and asPlayer() methods * Update UUID retrieval to use player controller * Change permission checking to use string-based hasPermission() with asBoolean() * Remove unused Permission import - Update AllaySparkCommand to use string-based permission format: * Replace Permission.createForCommand() with direct permission string "spark.command.spark" * Remove unused Permission import - Fix AllaySparkPlugin getCommandSenders() to properly handle player entities: * Map players to controlled entities * Filter out null entities - Adapt to breaking changes in allay-api 0.17.0 release
- Remove deprecated Permission class usage, use permission strings directly - Fix CommandSender type compatibility in getCommandSenders() - Update permission checking to use Tristate.asBoolean() - Simplify UUID retrieval using player.getUniqueId() - Change permission from 'spark.command.spark' to 'spark.command'
feat(allay): adapt allay-api 0.17.0 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This PR adds support for allay platform
Allay is a third-party server software for Minecraft: Bedrock Edition written in Java with the goal of maintaining high scalability while maintaining high performance through a well-designed architecture. Some of our users have been using our implementation for a while! However, we think having an official build would be better.
It would be nice to also update the spark docs, maybe I can open another PR to update docs. Thanks!