Make scala_db_test targets debuggable#7
Open
jadenPete wants to merge 14 commits into
Open
Conversation
… fix header_ bug from rules_jvm_external. The Scala 2 SDK was quite simple and included essentially just a library and compiler. The Scala 3 SDK has many more dependencies. This is a quick and hacky way of setting this up. Long term, this should be modified such that the SDK jars are pulled from the Scala toolchain. This also fixes the bug caused by rules_jvm_external prepending header_ to the compile jars. The header_ prefix breaks some things in the IntelliJ Scala plugin, so long term, we should work with the rules_jvm_external folks to fix that.
See bazelbuild#176 (comment) for context
… header_ This fixes jars being missed in the Scala SDK finder/creator.
| SCALA_TEST("scala_test", LanguageClass.SCALA, RuleType.TEST), | ||
| SCALA_JUNIT_TEST("scala_junit_test", LanguageClass.SCALA, RuleType.TEST); | ||
| SCALA_JUNIT_TEST("scala_junit_test", LanguageClass.SCALA, RuleType.TEST), | ||
| SCALA_DB_TEST("_scala_db_test", LanguageClass.SCALA, RuleType.TEST); |
There was a problem hiding this comment.
let's see if just checking that it's a _test and checking for a java info output group would suffice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.