chore: release main#7
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
0a745c4 to
ecc49f2
Compare
ImLunaHey
added a commit
that referenced
this pull request
May 31, 2026
Phase 5.9 item #7 — `g_input_stream_read` ran on the libsoup async-callback thread (= main GMainContext = main UI thread). Multi-MB downloads at network rates kept the main loop stuck inside `onSoupSendFinish` for seconds; GTK paint + JS pump both stalled. Refactors the body-read into `readBodyLoop` on a detached std::thread: main thread (onSoupSendFinish) worker (readBodyLoop) ────────────────────────── ─────────────────── soup_session_send_finish open ofstream parse Content-Length for each 256 KiB chunk: spawn std::thread → g_input_stream_read out.write (throttled) g_idle_add( onDownloadProgress) out.close g_idle_add(onDownloadDone) Both `onDownloadProgress` and `onDownloadDone` fire back on the main thread via `g_idle_add(G_PRIORITY_DEFAULT_IDLE, ...)` — the jsi callbacks the JS bindings register assume main-thread execution under our current threading model (they call `state().runtime` directly), so the hop preserves that contract. DownloadFinish + DownloadProgressHop are heap-alloc'd carriers between the worker and the main-thread completion; the worker hands ownership across and the main-thread callback frees them after firing the JS callbacks. Cancellation still uses ctx->cancellable — the read loop checks it on every g_input_stream_read, so a `fsDownloadCancel` from JS during a multi-second transfer terminates the worker within one chunk (256 KiB ≈ 100 ms at slow rates) and surfaces "cancelled" through onError.
f157347 to
3c8260f
Compare
62271c8 to
a50bc59
Compare
a50bc59 to
bb05cf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
react-native-linux: 0.1.0
0.1.0 (2026-06-01)
⚠ BREAKING CHANGES
Features
Bug Fixes
Miscellaneous Chores
react-native-linux-cli: 0.1.0
0.1.0 (2026-06-01)
⚠ BREAKING CHANGES
Features
Bug Fixes
Miscellaneous Chores
This PR was generated with Release Please. See documentation.