CI canonicalization: GitHub Actions, TagBot/CompatHelper/Dependabot, compat bounds, Runic formatting, typo fixes#37
Closed
ChrisRackauckas-Claude wants to merge 7 commits into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
…Helper, Dependabot Tests/Downgrade/FormatCheck/SpellCheck reuse the public SciML/.github reusable workflows; TagBot and CompatHelper use the standard upstream templates so they work with the default GITHUB_TOKEN outside the SciML org. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ODEInterface_jll 0.0.2 (the version with the Julia 1.12 loading fix layout) itself requires Julia >= 1.10, so 1.10 LTS is the supported floor. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
`10.^[...]` is a parse error on all Julia 1.x versions; use `10.0 .^ [...]`. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Vendored Fortran sources, LICENSE.md, and generated example artifacts (tex/ipynb/mw) are excluded from the typos check; Fortran identifiers (contex, contro, implct, nd) and citation names (Stoer, Numer. Math.) are allowlisted. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This was referenced Jun 12, 2026
Author
|
Closing in favor of splitting this into two focused PRs, as requested, to separate the CI/infrastructure pieces from the actual code changes:
#39 depends on #38 (its FormatCheck/SpellCheck checks enforce the standards applied in #38), so #38 should be merged first. Both are drafts and should be ignored until reviewed by @ChrisRackauckas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be ignored until reviewed by @ChrisRackauckas.
This is the CI canonicalization promised in #35 (and it completes what #30 and #31 started). It builds on top of the merged JLL adoption (#36). It deliberately does not touch the memory-model items deferred in #35, and it does not change any solver code semantics.
What changed
CI / automation (
.github/)1, plusmin(resolves to the 1.10 compat floor) andpreon Linux, via the public reusable workflowSciML/.github/.github/workflows/tests.yml@v1(same pinning convention as SciML/Sundials.jl, which is the model binary-wrapper repo). Includes Codecov upload; without aCODECOV_TOKENsecret the upload step is best-effort and never fails CI.typoscheck (reusable workflow), configured by_typos.toml.GITHUB_TOKEN, so they work as-is outside the SciML org)..travis.ymlandappveyor.yml.The four reused workflows are public and callable cross-org, so this repo gets SciML's maintained CI logic without moving anywhere; nothing in them assumes SciML-org secrets.
Project.toml
julia = "1.10"(LTS) floor:ODEInterface_jll = "0.0.2"(the JLL version current master loads) itself requires Julia ≥ 1.10, so 1.10 is the real floor.0.5.1(unregistered; master already bumped it after Fix Julia 1.12 compatibility issue with ODEInterface_jll loading #36). Note for review: since this drops Julia < 1.10 support relative to registered0.5.0, you may prefer releasing this as0.6.0instead — I left the number alone deliberately.Formatting
10.^[...]syntax that is a parse error on every Julia 1.x — fixed to10.0 .^ [...](separate commit) so the files parse at all.Typos
LICENSE.md, every Fortran source file (*.f,*.f90), and all author attributions —_typos.tomlexcludes them from the check, and allowlists Fortran identifiers (contex,contro,implct,nd) and citation names (Stoer, Numer. Math.) so CI never "corrects" them. README/Project.toml attribution to @luchr is unchanged.README
Local verification
Ran on this branch, both passing (
Testing ODEInterface tests passed):julia +1.10(1.10.11):Pkg.build("ODEInterface"); Pkg.test()— all 11 test sets passjulia +release(1.12.5):Pkg.build("ODEInterface"); Pkg.test()— all 11 test sets passUnmodified
masterwas also tested on both versions first (green), so any CI failure surfaced here is attributable to this PR. All files passrunic --check,typosexits clean, and the workflows passactionlint.Notes / follow-ups
CODECOV_TOKENrepo secret is added (optional).Closes #30. Closes #31.
🤖 Generated with Claude Code