Skip to content

close socket if logout #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swotex merged 1 commit into from
Jun 12, 2025
Merged

close socket if logout #180

swotex merged 1 commit into from
Jun 12, 2025

Conversation

@ltuffery
Copy link
Owner

@ltuffery ltuffery commented Jun 12, 2025

Description

Checklist

The following items should be checked before the pull request can be merged.

  • Unit tests added (if applicable).
  • The code formatted (e.g. with npm run format)

@ltuffery ltuffery requested a review from swotex June 12, 2025 12:40
@ltuffery ltuffery self-assigned this Jun 12, 2025
@ltuffery ltuffery added the bug Something isn't working label Jun 12, 2025
@ltuffery ltuffery linked an issue Jun 12, 2025 that may be closed by this pull request
Break client websocket when logout #156
Closed
swotex
swotex approved these changes Jun 12, 2025
View reviewed changes
Copy link
Collaborator

@swotex swotex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@swotex swotex merged commit 8f82426 into main Jun 12, 2025
1 check passed
@swotex swotex deleted the fix/issue-156-break-socket-client branch June 12, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swotex swotex swotex approved these changes

Assignees

@ltuffery ltuffery

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Break client websocket when logout

3 participants

@ltuffery @swotex