Skip to content

Fixed users without preferences or photos in the seeder. #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ltuffery merged 1 commit into from
Jun 1, 2025
Merged

Fixed users without preferences or photos in the seeder. #179

ltuffery merged 1 commit into from
Jun 1, 2025

Conversation

@ltuffery
Copy link
Owner

@ltuffery ltuffery commented May 22, 2025

Description

  • Fixed the photo warning caused by indexes 0 and 1 no longer existing (removed by array_diff).
  • Fixed the issue where users without preferences or photos were generated, even though they shouldn't exist. Instead of generating 50 users (php database/seeder.php -n 50), we were generating three times as many.

Checklist

The following items should be checked before the pull request can be merged.

  • Unit tests added (if applicable).
  • The code formatted (e.g. with npm run format)

@ltuffery ltuffery requested a review from swotex May 22, 2025 14:55
@ltuffery ltuffery self-assigned this May 22, 2025
@ltuffery ltuffery added the bug Something isn't working label May 22, 2025
@ltuffery ltuffery merged commit 4db70d1 into main Jun 1, 2025
1 check passed
@ltuffery ltuffery deleted the fix/photo-and-preference-factory branch June 1, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swotex swotex Awaiting requested review from swotex

Assignees

@ltuffery ltuffery

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ltuffery