Skip to content

DM-51401: Ensure subTest arguments are strings. #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timj merged 1 commit into from
Nov 18, 2025
Merged

DM-51401: Ensure subTest arguments are strings. #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/test_dipoleFitter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,29 +187,29 @@ def _checkTaskOutput(self, dipoleTestImage, sources, noPreImages=False):
# self.assertFloatsAlmostEqual(record['ip_diffim_DipoleFit_instFluxErr'],
# ???, rtol=rtol)
# emperical uncertainty values: not clear how to compute proper expected values.
with self.subTest(i=i, type="pos_xErr"):
with self.subTest(i=repr(i), type="pos_xErr"):
self.assertFloatsAlmostEqual(record['ip_diffim_DipoleFit_pos_xErr'],
.53*record["base_SdssCentroid_xErr"],
rtol=0.1 if not noPreImages else 0.5)
with self.subTest(i=i, type="pos_yErr"):
with self.subTest(i=repr(i), type="pos_yErr"):
self.assertFloatsAlmostEqual(record['ip_diffim_DipoleFit_pos_yErr'],
.53*record["base_SdssCentroid_yErr"],
rtol=0.1 if not noPreImages else 0.5)
with self.subTest(i=i, type="neg_xErr"):
with self.subTest(i=repr(i), type="neg_xErr"):
self.assertFloatsAlmostEqual(record['ip_diffim_DipoleFit_neg_xErr'],
.53*record["base_SdssCentroid_xErr"],
rtol=0.1 if not noPreImages else 0.5)
with self.subTest(i=i, type="neg_yErr"):
with self.subTest(i=repr(i), type="neg_yErr"):
self.assertFloatsAlmostEqual(record['ip_diffim_DipoleFit_neg_yErr'],
.53*record["base_SdssCentroid_yErr"],
rtol=0.1 if not noPreImages else 0.5)
# NOTE: these are smaller than the positive/negative uncertainties,
# because the of those covariance is negative!
with self.subTest(i=i, type="xErr"):
with self.subTest(i=repr(i), type="xErr"):
self.assertFloatsAlmostEqual(record['ip_diffim_DipoleFit_xErr'],
.34*record["base_SdssCentroid_xErr"],
rtol=0.06 if not noPreImages else 0.5)
with self.subTest(i=i, type="yErr"):
with self.subTest(i=repr(i), type="yErr"):
self.assertFloatsAlmostEqual(record['ip_diffim_DipoleFit_yErr'],
.35*record["base_SdssCentroid_yErr"],
rtol=0.06 if not noPreImages else 0.5)
Expand Down