chore(demo): Use _module.pageId for cross-module links#66
Open
StephanieJKS wants to merge 1 commit into
Open
Conversation
Request: commit the pending demo app changes Motivation: Demo app referenced module pages via hardcoded "module/page" strings, which break if a module entry is renamed or its scoping changes. Switching to _module.pageId makes the references resolve through the module system. Changes: - apps/demo/menus.yaml: profile, release-notes, users, logout menu links now resolve pageId via _module.pageId - apps/demo/pages/home.yaml: all home-page tile Link buttons (activities, user-admin, companies, contacts, notifications, profile, release-notes) use _module.pageId - apps/demo/pages/router.yaml: login/new redirect targets use _module.pageId - apps/demo/lowdefy.yaml: bump @lowdefy/community-plugin-mongodb 2.4.1 -> 3.0.0; normalize quote style to single quotes Tags: demo-app, module-pageid, cross-module-refs, menus, router, home-page, plugin-bump, mongodb-plugin $30m
JohannMoller
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
module/pagepage-id strings with_module.pageIdoperator references in the demo app's menus, home page, and router.@lowdefy/community-plugin-mongodbfrom 2.4.1 to 3.0.0 and normalize quote style inapps/demo/lowdefy.yaml.Why
Hardcoded
module/pagestrings break when a module entry is renamed or rescoped. Resolving page ids through the module system makes the demo a clean reference for the documented pattern.Test plan
pnpm ldf:b(or equivalent) builds the demo app without errorsPR Checklist
/r:docs-update- Documentation updated for behavioral changes/r:pr-review- Self-review completed before requesting team review