Stop double-decoding gzip #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default em-http decodes gzip content and leaves the Content-Encoding header intact, which is then detected by Faraday middleware and the gzip decoding is attempted again leading to exceptions. This change requests that em-http *not* handle the gzip decoding, so that the Faraday middleware can do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default em-http decodes gzip content and leaves the Content-Encoding header
intact, which is then detected by Faraday middleware and the gzip decoding is
attempted again leading to exceptions.
This change requests that em-http not handle the gzip decoding, so that the
Faraday middleware can do it.