BUGFIX: pubsub subscription should be unique per channelName#1
Open
marcoancona wants to merge 4 commits intolosandes:masterfrom
Open
BUGFIX: pubsub subscription should be unique per channelName#1marcoancona wants to merge 4 commits intolosandes:masterfrom
marcoancona wants to merge 4 commits intolosandes:masterfrom
Conversation
Currently `MongoAdapter.prototype.add()` subscribes the adaptor for every user joining the channel, which is wrong. As a consequence, when multiple users join a room, `MongoAdapter.prototype.onmessage()` is called for every message - and for every user - causing multiple broadcast of the same message.
This fix a bug that prevented new subscriptions to a channel even when no active subscription were present
Owner
|
@marcoancona: apologies, I missed the notification of this PR, and just noticed it when answering an Issue/Question. Would you mind providing a unit test for this in socketio-mongodb.fixture.js? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
MongoAdapter.prototype.add()subscribes the adaptor for every user joining the channel, which is wrong. As a consequence, when multiple users join a room,MongoAdapter.prototype.onmessage()is called for every message - and for every user - causing multiple broadcast of the same message.