-
Notifications
You must be signed in to change notification settings - Fork 27
ENH: Add the GPURenderDemo example. #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add the GPURenderDemo.cxx example from the VTK source tree to the VTK wiki examples repository along with the necessary input data.
|
@acbauer This example does not really fit into the simplicity criterion, but I think it is interesting and demonstrates a whole lot of concepts and possibilities. If not, we can reject the PR. Now, I'm also aware that when using the a GPU version of whatever class it is usually interesting to know its advantages or performance compared to the common version. Should we address this? @lorensen I was unable to run the example with other input data, such as DICOM or MHA files. Even within the VTK source tree I got a black render window. The same happened to the |
|
I'm a bit uncomfortable with copying something from VTK examples to this repo since they could easily get out of sync. I'd think that maybe a better way would be to just somehow link to the example in VTK from the wiki page. Also, it's a bad idea to remove the VTK copyright section from the original file, especially when you're pushing to one of the copyright holder's github repos :) I wouldn't think that Bill, Ken or Will would strenuously object to that though but better to avoid that issue from the start in my opinion. That does bring up a good point though -- these examples should probably have some type of license associated with them. This provides other developers a known way of using these example. Maybe they already do though and I just missed it. |
|
Concerning the copyright notice, I do agree that completely removing it is not probably a good idea; I just noticed that those examples that I looked at did not have it, and simply removed it, but I should have asked. Sorry. |
|
No big deal to me about the copyright notice and I'd bet that Bill, Will and Ken wouldn't care about it either, especially since it's in VTK-related stuff. I think the more important thing is that there is some type of copyright/license with these examples so that others know exactly how and how NOT to use them. You'd probably be surprised at how often parts of these examples are copy-and-pasted into other codes (as I think they should be). Since the BSD-style VTK license is meant to be highly non-intrusive it makes it easy for others to know that they can use it safely without fear of lawsuits, etc. Also, Github has been strongly encouraging projects to include some copyright |
|
This is linked to at the bottom of each example:
https://creativecommons.org/licenses/by/2.5/
…On Thu, Apr 27, 2017 at 5:59 PM, Andrew Bauer ***@***.***> wrote:
No big deal to me about the copyright notice and I'd bet that Bill, Will
and Ken wouldn't care about it either, especially since it's in VTK-related
stuff. I think the more important thing is that there is some type of
copyright/license with these examples so that others know exactly how and
how NOT to use them. You'd probably be surprised at how often parts of
these examples are copy-and-pasted into other codes (as I think they should
be). Since the BSD-style VTK license is meant to be highly non-intrusive it
makes it easy for others to know that they can use it safely without fear
of lawsuits, etc.
Also, Github has been strongly encouraging projects to include some
copyright
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUFDEuLUzvfbgUHO2fnqWQGlaUwmPd3ks5r0Q-ogaJpZM4NKy4T>
.
--
Unpaid intern in BillsBasement at noware dot com
|
|
also, I could add a copyright in the bottom section of each example. That
part pf the example is held in a wiki template.
On Thu, Apr 27, 2017 at 6:04 PM, Bill Lorensen <bill.lorensen@gmail.com>
wrote:
… This is linked to at the bottom of each example:
https://creativecommons.org/licenses/by/2.5/
On Thu, Apr 27, 2017 at 5:59 PM, Andrew Bauer ***@***.***>
wrote:
> No big deal to me about the copyright notice and I'd bet that Bill, Will
> and Ken wouldn't care about it either, especially since it's in VTK-related
> stuff. I think the more important thing is that there is some type of
> copyright/license with these examples so that others know exactly how and
> how NOT to use them. You'd probably be surprised at how often parts of
> these examples are copy-and-pasted into other codes (as I think they should
> be). Since the BSD-style VTK license is meant to be highly non-intrusive it
> makes it easy for others to know that they can use it safely without fear
> of lawsuits, etc.
>
> Also, Github has been strongly encouraging projects to include some
> copyright
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#10 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAUFDEuLUzvfbgUHO2fnqWQGlaUwmPd3ks5r0Q-ogaJpZM4NKy4T>
> .
>
--
Unpaid intern in BillsBasement at noware dot com
--
Unpaid intern in BillsBasement at noware dot com
|
|
We . plan on removing the code form VTK/Examples and put a README that
points to the wiki examples.
…On Thu, Apr 27, 2017 at 5:45 PM, Andrew Bauer ***@***.***> wrote:
I'm a bit uncomfortable with copying something from VTK examples to this
repo since they could easily get out of sync. I'd think that maybe a better
way would be to just somehow link to the example in VTK from the wiki page.
Also, it's a bad idea to remove the VTK copyright section from the
original file, especially when you're pushing to one of the copyright
holder's github repos :) I wouldn't think that Bill, Ken or Will would
strenuously object to that though but better to avoid that issue from the
start in my opinion.
That does bring up a good point though -- these examples should probably
have some type of license associated with them. This provides other
developers a known way of using these example. Maybe they already do though
and I just missed it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUFDObMKLZX9dcrE9S6YxFJJJpBi2dhks5r0QxngaJpZM4NKy4T>
.
--
Unpaid intern in BillsBasement at noware dot com
|
Add the GPURenderDemo.cxx example from the VTK source tree to the VTK wiki
examples repository along with the necessary input data.