Skip to content

Remove integer and floats from Proptypes #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deanrobertcook wants to merge 1 commit into from
Closed

Remove integer and floats from Proptypes #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-nipple/lib/ReactNipple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,9 +255,9 @@ var ReactNipple = (_class = function (_Component) {
className: _propTypes2.default.string,
options: _propTypes2.default.shape({
color: _propTypes2.default.string,
size: _propTypes2.default.integer,
threshold: _propTypes2.default.float, // before triggering a directional event
fadeTime: _propTypes2.default.integer, // transition time
size: _propTypes2.default.number,
threshold: _propTypes2.default.number, // before triggering a directional event
fadeTime: _propTypes2.default.number, // transition time
multitouch: _propTypes2.default.bool,
maxNumberOfNipples: _propTypes2.default.number, // when multitouch, what is too many?
dataOnly: _propTypes2.default.bool, // no dom element whatsoever
Expand Down Expand Up @@ -288,4 +288,4 @@ var ReactNipple = (_class = function (_Component) {

return ReactNipple;
}(_react.Component), (_applyDecoratedDescriptor(_class.prototype, 'handleElement', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleElement'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickStart', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickStart'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickEnd', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickEnd'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickMove', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickMove'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickDir', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickDir'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickPlain', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickPlain'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickShown', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickShown'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickHidden', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickHidden'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickPressure', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickPressure'), _class.prototype)), _class);
exports.default = ReactNipple;
exports.default = ReactNipple;
6 changes: 3 additions & 3 deletions packages/react-nipple/src/ReactNipple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ export default class ReactNipple extends Component {
className: PropTypes.string,
options: PropTypes.shape({
color: PropTypes.string,
size: PropTypes.integer,
threshold: PropTypes.float, // before triggering a directional event
fadeTime: PropTypes.integer, // transition time
size: PropTypes.number,
threshold: PropTypes.number, // before triggering a directional event
fadeTime: PropTypes.number, // transition time
multitouch: PropTypes.bool,
maxNumberOfNipples: PropTypes.number, // when multitouch, what is too many?
dataOnly: PropTypes.bool, // no dom element whatsoever
Expand Down