Skip to content

Find by glob pattern#1

Merged
looplj merged 1 commit intomasterfrom
development
Mar 24, 2026
Merged

Find by glob pattern#1
looplj merged 1 commit intomasterfrom
development

Conversation

@looplj
Copy link
Copy Markdown
Owner

@looplj looplj commented Mar 24, 2026

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the graphql-cli tool by introducing a new command for updating existing GraphQL endpoint configurations and by greatly improving the schema search functionality. Users can now modify endpoint details like URLs and headers more easily, and the find command offers more precise and detailed schema exploration through glob pattern matching and an option to view full type definitions.

Highlights

  • Enhanced find command: The graphql-cli find command now supports glob patterns (*, ?, [...]) for searching schema definitions, allowing for more flexible and powerful searches. Additionally, a new --detail flag has been introduced to display full definitions with fields and arguments, rather than just names.
  • New update command: A new graphql-cli update command has been added, enabling users to modify existing endpoint configurations. This command supports updating the endpoint URL, description, and HTTP headers, with headers being merged to preserve existing ones not explicitly changed.
  • Documentation updates: The README.md and SKILL.md files have been updated to reflect the new update command and the enhanced capabilities of the find command, including examples for glob patterns and the --detail flag.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/ci.yml
    • .github/workflows/release.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a new update command for modifying existing endpoint configurations and enhances the find command with glob pattern matching and a --detail flag. Documentation in README.md and SKILL.md has been updated to reflect these changes, which is well-done. The implementation of glob matching in internal/schema/finder.go and the conditional printing in internal/printer/printer.go are correctly handled. However, a critical issue was identified in the new cmd/update.go file where a function parseHeader is used without being defined or imported, which will cause a compilation failure.

headers := make(map[string]string)

for _, h := range updateHeaders {
k, v, ok := parseHeader(h)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The parseHeader function is used here but is not defined within this file or imported from another package in the provided context. This will lead to a compilation error. Please define this helper function or import it if it exists elsewhere.

@looplj looplj merged commit f17e4c7 into master Mar 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant