This repository was archived by the owner on Nov 30, 2021. It is now read-only.
Allowing use of proxy with http streaming#78
Open
corinnekunze wants to merge 1 commit intolooker:masterfrom
Open
Allowing use of proxy with http streaming#78corinnekunze wants to merge 1 commit intolooker:masterfrom
corinnekunze wants to merge 1 commit intolooker:masterfrom
Conversation
corinnekunze
force-pushed
the
proxy-streaming
branch
from
8b93592 to
92573df
Compare
Contributor
|
Hi Corrine, Great! Thanks for looking into this and submitting the PR. I'll get someone to check this out shortly. -Danny |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We need to use streaming as well as through a proxy.
I noticed there wasn't functionality to do that but you have the ability to define
proxyas a config when you initialize theLookerSDK::Client.So I tapped into that so if a
proxyvariable is defined it'll try to use that with theNet::HTTP::Proxyclass and chain it to the streaming request.I've tested this in our app and it seems to be allowing the request through.
Not seeing any groundwork for testing of this
StreamingClientthough, that makes it difficult to write a test for this.