Fix: Improve GCS Action error handling and logging#705
Fix: Improve GCS Action error handling and logging#705jeffrey-martinez wants to merge 4 commits intomasterfrom
Conversation
jeffrey-martinez
commented
Dec 12, 2025
- Prevent 'undefined' error messages by stringifying the error object if message is missing.
- Log the full original error object for better debugging visibility.
- Prevent 'undefined' error messages by stringifying the error object if message is missing. - Log the full original error object for better debugging visibility.
Summary of ChangesHello @jeffrey-martinez, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the error handling and logging within the Google Cloud Storage (GCS) action. The changes ensure that error messages are always informative, even when the original error object lacks a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves error handling and logging for the Google Cloud Storage action. The changes ensure that error messages are always defined and that the original error object is logged for better debugging. I've found a potential critical issue in the new error handling logic where it could crash if the caught error is null or undefined. I've provided a suggestion to make the error message generation more robust and prevent this crash.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…n-source/actions into fix/gcs-action-error-handling