Skip to content

Fix: Improve GCS Action error handling and logging#705

Open
jeffrey-martinez wants to merge 4 commits intomasterfrom
fix/gcs-action-error-handling
Open

Fix: Improve GCS Action error handling and logging#705
jeffrey-martinez wants to merge 4 commits intomasterfrom
fix/gcs-action-error-handling

Conversation

@jeffrey-martinez
Copy link
Contributor

  • Prevent 'undefined' error messages by stringifying the error object if message is missing.
  • Log the full original error object for better debugging visibility.

- Prevent 'undefined' error messages by stringifying the error object if message is missing.
- Log the full original error object for better debugging visibility.
@jeffrey-martinez jeffrey-martinez requested a review from a team as a code owner December 12, 2025 19:48
@gemini-code-assist
Copy link

Summary of Changes

Hello @jeffrey-martinez, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the error handling and logging within the Google Cloud Storage (GCS) action. The changes ensure that error messages are always informative, even when the original error object lacks a message property, and provide richer debugging information by logging the complete original error object. This leads to more reliable error reporting and easier troubleshooting.

Highlights

  • Robust Error Message Generation: Implemented logic to prevent 'undefined' error messages by attempting to stringify the error object if its message property is missing, falling back to 'Unknown Error' if stringification also fails.
  • Enhanced Debugging Visibility: The full original error object is now included in the winston.error logs, providing more comprehensive context for debugging.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves error handling and logging for the Google Cloud Storage action. The changes ensure that error messages are always defined and that the original error object is logged for better debugging. I've found a potential critical issue in the new error handling logic where it could crash if the caught error is null or undefined. I've provided a suggestion to make the error message generation more robust and prevent this crash.

jeffrey-martinez and others added 3 commits December 12, 2025 12:09
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…n-source/actions into fix/gcs-action-error-handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant