input: Add context_menu option to support disable ContextMenu.#1770
Closed
pedrobartolini wants to merge 2 commits intolongbridge:mainfrom
Closed
input: Add context_menu option to support disable ContextMenu.#1770pedrobartolini wants to merge 2 commits intolongbridge:mainfrom
context_menu option to support disable ContextMenu.#1770pedrobartolini wants to merge 2 commits intolongbridge:mainfrom
Conversation
…tion menu Popovers already use defer_draw to render above other content, and when you right-click an input inside a popover (triggering a context menu which also uses defer_draw), you get nested deferred drawing → panic. This option allows users to safely right-click inputs inside popovers.
Member
|
This not the best way to solve issue, let me think about. |
huacnlee
changed the title
context_menu option to support disable ContextMenu.
Member
|
Close this by zed-industries/zed#47770 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Popovers already use defer_draw to render above other content, thus right-clicking an input inside a popover (triggering a context menu which also uses defer_draw), you get nested deferred drawing → panic.
This small change allows users to disable the menu, making it safe to right-click inputs inside popovers.
How to Test