Open
Conversation
replaced _defaults_ with _doc
jsvd
reviewed
May 30, 2018
| "_all": { "enabled": false }, | ||
| "_source": { "compress": true }, | ||
| "properties" : { | ||
| "_doc": { |
Member
There was a problem hiding this comment.
since _doc is only allowed in elasticsearch 6.2+ (prior to this types can't start with underscore), I'm a bit concerned with accepting this change, which won't work for anyone testing with a <6.2 es cluster. thoughts?
Author
There was a problem hiding this comment.
defaults is not allowed in elasticsearch 6.*
So it's similar concern I suppose?
Member
There was a problem hiding this comment.
unfortunately this is not obvious but _default_ is treated differently. Installing a template with _default_ on 6.1.2 will work, but _doc not.
That said, the template as it is doesn't work on 6.1.2 either because it still uses the string type which is no longer valid since 6.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaced defaults with _doc
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/