Fix broken identity map flush test#303
Open
robbavey wants to merge 1 commit intologstash-plugins:mainfrom
Open
Fix broken identity map flush test#303robbavey wants to merge 1 commit intologstash-plugins:mainfrom
robbavey wants to merge 1 commit intologstash-plugins:mainfrom
Conversation
Following logstash-plugins/logstash-codec-multiline#70, clones of the codec are used, rather than the original codec, causing the codec tracer not to be able to trace events that occurred after the clone. This commit removes the physical clone on the CodecTracer, rather treating it as another function to be traced, returning the same Tracer instance, but adding a clone event instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following logstash-plugins/logstash-codec-multiline#70,
clones of the codec are used, rather than the original codec, causing the codec
tracer not to be able to trace events that occurred after the clone. This
commit removes the physical clone on the CodecTracer, rather treating it as another
function to be traced, returning the same Tracer instance, but adding a clone event
instead.