fix(doctor): use configured localnet port instead of hardcoded 3040#41
fix(doctor): use configured localnet port instead of hardcoded 3040#41teyrebaz33 wants to merge 1 commit into
Conversation
| Start { timeout_sec: u64 }, | ||
| Stop, | ||
| Status { json: bool }, | ||
| Logs { tail: usize }, |
There was a problem hiding this comment.
json parameter seems to be from another change/PR?
There was a problem hiding this comment.
You're right, thanks for catching that! The json field on Logs is part of PR #39 (feat: add --json flag to localnet logs). This PR (#41) only changes src/commands/doctor.rs to use project.config.localnet.port instead of the hardcoded 3040. The extra commit appeared here because this branch was created from the same base. I can rebase to isolate just the doctor fix if that would help.
There was a problem hiding this comment.
seems the unrelated change is still here
|
I've rebased this PR onto master so it now contains only the doctor fix commit — the |
39c19df to
0f9a304
Compare
|
Branch has been force-pushed and now contains exactly 1 commit with 2 files changed: |
0f9a304 to
616bb1f
Compare
616bb1f to
6ebface
Compare
|
Thanks @teyrebaz33. Holding off on a detailed review — what review is finding points at process gaps worth closing first. Please revise against the points below, then ping me for another pass. The repo's
|
Closes #40
Problem
doctorhardcodes127.0.0.1:3040for the sequencer port check, ignoring thelocalnet.portvalue inscaffold.toml. This means projects using a non-default port always see the sequencer reported as unreachable indoctoroutput.Fix
Use
project.config.localnet.portto build the address and label dynamically — consistent with howlocalnet start,localnet status, andlocalnet stopalready behave.Changes
src/commands/doctor.rs: derivelocalnet_addrandsequencer_port_labelfrom project configtests/cli.rs: new test verifying doctor uses configured port, not hardcoded 3040Testing
cargo test doctor_uses_configured_localnet_port