ci: add bench-regression workflow for crypto_primitives_bench#494
Open
moudyellaz wants to merge 1 commit into
Open
ci: add bench-regression workflow for crypto_primitives_bench#494moudyellaz wants to merge 1 commit into
moudyellaz wants to merge 1 commit into
Conversation
Benchmark for 58134a0Click to view benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Purpose
Add a
bench-regressionGitHub workflow that usesboa-dev/criterion-compare-actionto gatecrypto_primitives_benchagainst the base branch on every PR that touches the watched paths. Follow-up to #488 (the criterion migration); deferred to this PR because the action needs the criterion bench to exist on both head and base.⚙️ Approach
Workflow triggers on PRs touching
tools/crypto_primitives_bench/**,key_protocol/**,nssa/core/**, or the workflow file itself. One job runs the action against the PR base, withcwd: tools/crypto_primitives_benchandbenchName: primitives. The action posts the comparison as a PR comment..github/workflows/bench-regression.yml.🧪 How to Test
Open this PR; the workflow self-triggers because it touches the watched path (the workflow file itself). The first run on this PR will compare against main and post a no-change diff (since this PR doesn't touch bench code).
🔗 Dependencies
#488 merged. Main now has
tools/crypto_primitives_bench/benches/primitives.rsfor the action to compare against.🔜 Future Work
None.
📋 PR Completion Checklist