fix(workspace): disable risc0-zkvm default features to avoid ring in guest builds#482
Closed
ygd58 wants to merge 2 commits into
Closed
fix(workspace): disable risc0-zkvm default features to avoid ring in guest builds#482ygd58 wants to merge 2 commits into
ygd58 wants to merge 2 commits into
Conversation
…guest builds Add explicit prove feature to nssa which uses ExecutorEnv, default_prover. Workspace already has default-features = false; this PR adds the nssa fix. Fixes logos-blockchain#468
Contributor
Author
Collaborator
|
Hey @ygd58 , I think you should have added |
…o nssa - Workspace Cargo.toml: disable risc0-zkvm default features (bonsai, client) to avoid ring cross-compile failure for riscv32im targets - nssa/Cargo.toml: add explicit prove feature since nssa uses ExecutorEnv, default_prover, and default_executor which require the prove feature - Regenerate artifacts Fixes logos-blockchain#468
Contributor
Author
|
Updated — now includes both changes:
Artifacts regenerated. @Arjentix |
Collaborator
|
@ygd58 , hey, sorry for the delay. Can you rebase and rebuild artifacts again? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased on latest main and regenerated artifacts.
Changes:
Cargo.toml:risc0-zkvm = { version = "3.0.5", default-features = false, features = ['std'] }nssa/Cargo.toml: explicitprovefeature for ExecutorEnv/default_prover/default_executorFixes #468