Release 4.3.x

[logicallysynced]

Brings master from 4.1.38 to 4.3.1 - 475 commits covering the 4.1.44 to 4.2.73 releases plus the 4.3.1 audit pass. Everything here has already shipped to users through the Velopack update channel except 4.3.1, which is the release this PR prepares.

What each version added

• 4.1.44: QMK Raw HID keyboard support (Beta) with a pre-built layout database covering 2650 boards.
• 4.2.50: Windows Dynamic Lighting, Yeelight and Alienware LightFX support (all Beta), layer copying between devices, Hue/LIFX/Yeelight in the first-run wizard, multi-zone keyboard layouts, code-signed installers, and a batch of fixes (Vegas Mode in the Gold Saucer, title animation during zone loads, clipboard loss on close).
• 4.2.65: EVision keyboard support (13 boards on the Sonix VS11K28A firmware), Redragon mouse support (13 models), updated Corsair/CoolerMaster/MSI/Wooting SDKs, and a fix for Corsair and OpenRGB providers failing to start.
• 4.2.73: FFXIV 7.51 support, layer remapping on keyboard-type change, AZERTY fixes, a crash fix when changing layer modes, and two Enmity Tracker fixes (dark while engaged, dark after disable/re-enable).
• 4.3.1: a codebase audit. 10 subsystem auditors produced 67 findings; adversarial verification confirmed 47, and 44 were fixed (the other 3 are credential-handling items in private build scripts, handled outside the repo). Details below.

The 4.3.1 audit, by area

Thread safety

• _runningEffects and _activeDevices in RGBController were plain collections written from device-SDK callback threads while the game loop and UI thread read them. Both now sit behind dedicated locks; teardown paths snapshot before detaching.
• _layergroups was a plain Dictionary mutated by the game loop while the RGB.NET timer thread read it through surface.Updating. It is now a ConcurrentDictionary, with all 24 processor write sites and 4 removal sites converted.
• Strobe and Pulse decorators could crash the render loop when detached mid-update. Both now carry the null guards and try/catch the Starfield family already had.
• The Sentry heartbeat blocked a thread-pool thread with Thread.Sleep(1500) every minute. It is now async end to end.

Logic bugs

• DamageFlash clamped every minimum-opacity value below 1.0 to zero, which disabled the scale-damage-flash setting for its entire useful range. The clamp now floors at 0.
• ArenaLightShow blended a 0-1 base color into a 0-255 channel scale, so the configured base color was invisible and the effect faded to black. Base channels are now scaled to match.
• Blacksmith characters got Black Mage palette colors from a copy-paste error in GameHelper.
• A missing assignment in DictionaryConverter threw NullReferenceException during settings deserialization on the fallback path.
• Yeelight marked colors as delivered even when the TCP send failed, so one Wi-Fi blip stopped a bulb painting until the provider was toggled. Send state now updates only on success, failures retry next frame, and errors surface once per outage instead of once per retry.
• The Hue adoption dialog mutated an ObservableCollection from a thread-pool thread after ConfigureAwait(false). Continuations now resume on the UI thread.
• TargetCastbar was the only processor missing its _disposed guard.
• Palette, effect and settings saves wrote directly to the target file, so a crash mid-write corrupted them. All three now use the same atomic tmp-and-replace pattern layer mappings already used.

Performance

• JobGaugeA/B/C rebuilt every LED group on every game tick in Interpolate mode. They now rebuild only when the gauge value changes, matching the guard HPTracker and the other trackers already had.
• Per-tick allocations removed across nine layer processors: cached brushes in Highlight, both BattleStances, JobClassesHighlight, JobClasses and TargetCastbar; a persistent dictionary in Keybinds; DamageFlash now allocates its decorator only when a flash actually fires; CutsceneAnimation allocated a StarfieldDecorator every tick and never used it.
• Per-frame buffer allocations removed in the DynamicLighting, Alienware, EVision, Redragon and QMK update queues, with wire output verified unchanged.
• LIFX and QMK held their device lock through inter-chunk pacing sleeps (up to 90ms for a 70-zone LIFX strip), which froze the UI thread when re-enabling a device from the Mappings tab. Packets are now built under the lock and sent with identical pacing outside it.
• GetLedArray ran an O(n*m) LINQ scan per frame; it now uses a HashSet.

Resource leaks

• LayerItemViewModel subscribed to the static localization event and never unsubscribed, leaking a full set of layer items on every refresh of the Mappings tab. The three device-adoption dialog view models had the same leak. All four now unsubscribe on disposal.
• The Yeelight Music Mode listener leaked its pending accept task and any late-arriving socket.
• SettingsViewModel held a registry key open for the life of the app; it is now scoped to each call.

Dead code

• The GameLoop CPU-throttle branch could never execute (its flag was set false on the line above the test) and is removed, along with a helper that read a memory counter and returned it as a CPU percentage.

Two findings needed no change on inspection (one was already in the recommended form, one targets an app-lifetime object where unsubscription buys nothing), and the harness gained a fix of its own: effect presets now round-trip all 28 parameters instead of a third of them.

Every fix was re-reviewed against the diff before commit. That second pass caught and corrected two regressions in the first round of fixes (a snapshot return that broke effect registration, and a stale-buffer repaint in Dynamic Lighting), one log-spam path, and one compile error.

CI

• nick-fields/retry bumped v3 to v4 in ci.yml (supersedes Bump nick-fields/retry from 3 to 4 #203; the v4 major only moves the action to the node24 runtime, which windows-latest runners already ship). Dependabot will close Bump nick-fields/retry from 3 to 4 #203 when this merges.

Verification

• Release build of all three projects: 0 warnings, 0 errors.
• Full test suite: 133/133 passing.
• Working tree grepped for signing-cert identity strings before each commit: clean.

🤖 Generated with Claude Code