Open
Conversation
Member
There was a problem hiding this comment.
Thanks for the PR!
LGTM overall, need to change the initialization
edit:
I'm not quite sure what the dev workflow is to test changes like this. Is the idea to run build.sh, and then manually manipulate the yaml to point to local files instead of the github.com hosted ones
Yeah pretty much. We don't have that many contributions to the official providers so we haven't improved that process yet
| if err != nil { | ||
| return nil, err | ||
| } | ||
| retOptions.StartupScript, err = fromEnvOrError("STARTUP_SCRIPT") |
Member
There was a problem hiding this comment.
I think you can make this optional by just reading os.Getenv("STARTUP_SCRIPT"). Right now it would fail if it's empty
|
This PR is exactly what I need, can we possibly get this merged 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding option to provide a startup script.
The lack of multiline inputs in the devpod UI does make it a bit ackward to use, but being able to manipulate the VM at startup time is important in some situations, like installing GPU drivers.
Fixes loft-sh/devpod#1429
I'm not quite sure what the dev workflow is to test changes like this. Is the idea to run build.sh, and then manually manipulate the yaml to point to local files instead of the github.com hosted ones?