Open
Conversation
CaMer0n
commented
Feb 18, 2021
| if ($this.is('.active')) { | ||
| if (!$prev.is('.d-none')) { | ||
| if (!$prev.is('.hidden')) { | ||
| $this.removeClass('active'); |
Author
There was a problem hiding this comment.
I guess this may need to be !$prev.is('.hidden') || !$prev.is('.d-none')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. I haven't tested this with Bootstrap4, but it definitely works with Bootstrap 3.
Bootstrap4 can use
ulanddivfor dropdown menus, but bootstrap3 onlyul. So version 2 did not work well with Bootstrap 3.I just realized (looking at the diff) that you implemented 'endKey', but it was not in the 'dist' version, only the 'src' version.
I added it as well. I needed the option to use a line-break
\nafter an insert, instead of a blank space.Also, long lists would flow off the page, so I add an overflow-y to the
ulin the css file.Anyway, a pull-request for your consideration.