RST-15588: remove spurious dependency#10
Open
ihadzic-locusrobotics wants to merge 1 commit into
Open
Conversation
catkin should not be the exec_depend in package manifest because the build tool should not be necessary at runtime. This actually breaks the ROS2 build (which shares the branch with ROS1) because there is no catkin in ROS2.
ihadzic-locusrobotics
requested review from
aantunes-locus,
avazahedi,
Copilot,
garyservin,
jprestwo and
nickovaras
There was a problem hiding this comment.
Pull request overview
Removes an incorrect runtime dependency on catkin from the root package.xml so the manifest works for ROS2 builds (where catkin is not available) while keeping the package as a plain cmake build type.
Changes:
- Dropped
<exec_depend>catkin</exec_depend>frompackage.xmlto avoid requiring the build tool at runtime.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
catkin should not be the exec_depend in package manifest because the build tool should not be necessary at runtime. This actually breaks the ROS2 build (which shares the branch with ROS1) because there is no catkin in ROS2.