-
-
Notifications
You must be signed in to change notification settings - Fork 12
Bulk delete Facebook posts #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
micahflee
wants to merge
53
commits into
main
Choose a base branch
from
582-facebook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65a10df to
163cefd
Compare
…he unknown account view
…vue global styles there too
…g your Facebook archive
…ive from Meta, and returns to the Dashboard
…eating delete job
…acebookViewModel settings before starting jobs
…o keep track of config and jobs
…and always report progress (even if 0 posts are deleted)
…d of just creating an in-memory array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #582, #617, #618.
This adds basic support for the Facebook platform. Some of the bigger things to note:
BaseViewModel.clickElementByXPathwhich makes development much faster, because in chrome/firefox dev tools, when inspecing an element, you can copy it's XPathBaseViewModel.safeExecuteJavaScriptwhich I think is a better way to execute js in the webview going forward, since it wraps it in all the error catching we needFeature flag
You need to enable the Facebook feature flag:
export CYD_FEATURE_FACEBOOK=1 npm run startArchive instructions
In the Facebook dashboard, clicking "Get Archive from Meta" links to https://docs.cyd.social/docs/facebook/get-archive, which is a broken link. To. view the instructions:
cd docs npm run startThen load http://localhost:3000/docs/next/facebook/get-archive.
Testing
Here are some of the things to test for, though you might think of others:
npm run config-local), and running a separate instance of cyd-server from this PR branch.npm run config-open) it should allow you to bypass premium gatingFuture work before we're ready
This is a huge PR so I'm going to stop for now, but there are a few things that I think we also need to handle, which I haven't really tackled here:
Handle rate limits. I don't have enough data in my test Facebook account to hit a rate limit, so I actually have no idea how Facebook handles them. Here's the issue: Facebook: handle rate limits #617Handle error reports. If something breaks (like it's trying to click a button that doesn't exist) it silently fails, but really it should submit an error report. Here's the issue: Facebook: handle error reports #618