[BUGFIX] Don't cache pages during solr indexing#465
Merged
Conversation
In EXT:solr version 14, indexing requests are executed via subrequests instead of HTTP/HTTPS. Additionally, query parameters were moved to a custom request attribute `solr.indexingInstructions`, which still allows identifying indexing requests. Due to the change to subrequests, it seems necessary to also trigger the `SolrIndexingProcessListener` with the CacheRuleEvent (PrepareMiddleware). Resolves: lochmueller#464
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In EXT:solr version 14, indexing requests are
executed via subrequests instead of HTTP/HTTPS.
Additionally, query parameters were moved
to a custom request attribute
solr.indexingInstructions,which still allows identifying indexing requests.
Due to the change to subrequests, it seems
necessary to also trigger the
SolrIndexingProcessListenerwith theCacheRuleEvent (PrepareMiddleware).
Resolves: #464
Short description
...
Related Issue
...
More Details