[HK][SONAR] using equals with hashCode#675
Draft
fgdrf wants to merge 1 commit into
Draft
Conversation
Change-Id: I15c03a9a0668e55b9f20492e1f2769a53d1ee182 Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Contributor
Author
|
this fixed sonar finding that classes that override equals() also override hashCode(). |
Contributor
Author
|
@sschulz92 investigating if the bahavior of equals changed due to missing check of which has been replaced by I guess I will add a test-case to verify .. |
Contributor
|
You have changed a missing check? I do not get the point tbh :D |
Contributor
Author
Eclipse allows to generate equals & hashCode using members of the class. the generated equals method change as mentioned and I'd like to check if tow different instances / sub-classes of this Abstract class returned equal=true in the past while the new version would say (different class) that these are not equals anymore. HTH |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I15c03a9a0668e55b9f20492e1f2769a53d1ee182
Signed-off-by: Frank Gasdorf fgdrf@users.sourceforge.net