Skip to content

Solve deprecation of ChangeCRSCommand#649

Merged
fgdrf merged 6 commits into
locationtech:masterfrom
sschulz92:REMOVE_DEPRECATED_CLASS_BasicCommandFactory
Jan 4, 2022
Merged

Solve deprecation of ChangeCRSCommand#649
fgdrf merged 6 commits into
locationtech:masterfrom
sschulz92:REMOVE_DEPRECATED_CLASS_BasicCommandFactory

Conversation

@sschulz92

Copy link
Copy Markdown
Contributor

Which ends in the deletion of BasicCommandFactory also

@sschulz92

Copy link
Copy Markdown
Contributor Author

I would like to ask for a review on this also @fgdrf :D

@fgdrf

fgdrf commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

This is related to #436 which I can update after this change.

so thanks for providing this cleanup of deprecated code. Wondering if its worth to add a hint in ‚What‘s new’ pages which Classes are not available anymore and what to use instead as a SDK user. Would you add a few lines?

I can have a look at other changes we have merged already

@sschulz92

Copy link
Copy Markdown
Contributor Author

Wondering if its worth to add a hint in ‚What‘s new’ pages which Classes are not available anymore and what to use instead as a SDK user. Would you add a few lines?

I did, it's okay like this?

@fgdrf fgdrf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for your effort

@fgdrf fgdrf merged commit 034d929 into locationtech:master Jan 4, 2022
@sschulz92 sschulz92 deleted the REMOVE_DEPRECATED_CLASS_BasicCommandFactory branch January 4, 2022 12:55
@fgdrf fgdrf added this to the 2.3.0 milestone Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants