add spotbugs feedback to workflow#552
Merged
Merged
Conversation
fgdrf
commented
Oct 8, 2021
fgdrf
commented
Contributor
- executes goal spotbugs:check
- adds report to list reported errors as feedback for pull-requests and master-builds
Contributor
Author
|
@sschulz92 before we proceed with spotbugs fixes (see #551 and #550) I'd like to get feedback about the current state. Then we see changes/improvements on every pull-request and can avoid introducing new issues while changing existing code. |
Contributor
Author
|
getting feedback for spotbugs increases build-time from ~3min to ~11min for the main compile-step, I guess its worth to wait a bit longer and provide details about the issues in the code-base |
Contributor
Author
|
Nice, current state : 350 spotbugs issues found, see https://github.com/locationtech/udig-platform/pull/552/checks?check_run_id=3843521836 Just note that we report errors only (see pom.xml for spotbugs-maven-plugin) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.