Open
Conversation
bddba3a to
94d060f
Compare
94d060f to
f5a5ba3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues:
cdklocal bootstrapdoes not respect AWS_ENDPOINT_URL variable #103A little context for the proposed changes
I have spent at least several hours setting up the environment to point the vanilla AWS CDK CLI to LocalStack.
I have checked the changelogs for the AWS SDK for JavaScript, the AWS CDK CLI, and LocalStack.
And I want to share what I think the way for
aws-cdk-localis:aws-sdk-jsv3 that respects environment variables just like AWS CLI does.cdk(local) watch --hotswap, IMHO, is a more convenient alternative.2.1109.0, so supporting AWS CDK versions prior tov2.14is irrational.Tested against LocalStack running in Docker: