A complete Persian (FA) translation and some minor corrections in the English file#711
A complete Persian (FA) translation and some minor corrections in the English file#711grunch merged 16 commits intolnp2pBot:mainfrom
Conversation
WalkthroughUpdated the English localization file ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
locales/en.yaml (1)
428-435: Template variable rename creates breaking change: code still passesidbut en.yaml expectsorderId.The code in
bot/messages.ts(line 1854) passesid: order._idto renderpending_payment_success, but the en.yaml template now expects${orderId}. This mismatch will cause the order ID to render blank for English users. Synchronize the parameter name in the code toorderIdto match the template, or revert the template variable back to${id}.Note: Other locale files (it, pt, ru, ko, uk, es, fa, fr, de) still use
${id}in theirpending_payment_successtemplates, so only en.yaml was changed. This inconsistency across locales should also be addressed.
🧹 Nitpick comments (2)
locales/en.yaml (2)
25-25: Clarify/fiatsentusage (with/without order id) to match the bot’s actual command signature.
Right now the instructions say “use the /fiatsent command”, but/helpdocuments/fiatsent <_order id_>while other copy shows/fiatsentwithout an id (e.g.,fiatsent_order_cmd: /fiatsent). If the handler requires an id, this line should say/fiatsent ${orderId}(or explicitly mention selecting the order in-chat).
82-88: Wording is still ambiguous (“add the parameter 0 indicating sats amount”).
Consider tightening to “add0as the sats amount” and split the sentence for readability.- In order to create a sale with a surplus in the price of 3% \(premium\) you need to add the parameter 0 indicating sats amount\. The bot will calculate the selling price using the Bitcoin market price and applying the indicated surplus, you need to add 3 as the last parameter + To create a sale with a 3% premium, set the sats amount to 0\. The bot will calculate the sats amount from the market price and apply the premium\. Then add 3 as the last parameter\.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
locales/en.yaml(4 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: lnp2pBot/bot PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-10-22T14:03:55.114Z
Learning: Applies to {bot/**,locales/*.json} : Pair new bot flows with corresponding text updates under locales/
📚 Learning: 2025-08-14T18:53:14.640Z
Learnt from: CR
Repo: lnp2pBot/bot PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-08-14T18:53:14.640Z
Learning: Follow the Lightning Network hold-invoice escrow flow for buy and sell orders as documented
Applied to files:
locales/en.yaml
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
| Proof of payment: ${paymentSecret} | ||
| pending_payment_success: | | ||
| I have paid the lightning invoice for ${amount} satoshis, order ID: ${id}! | ||
| I have paid the lightning invoice for ${amount} satoshis, order ID: ${orderId}! |
There was a problem hiding this comment.
Hi @RamzArzFarsi Thanks for your first contribution!
Was there a specific reason for changing it to ${orderId}?
${id} was used because this template serves dual purposes, it handles both order payments (order._id) and community payments (community.id).
Just want to make sure we maintain compatibility with both use cases.
There was a problem hiding this comment.
I noticed the order ID placeholder was ${orderId} in the entire file except for this one particular place. I assumed it must be a typo.
There was a problem hiding this comment.
I changed it back.
There was a problem hiding this comment.
The old Persian file had weird phrasings and felt like a draft LLM translation.
This is a more refined and natural-sounding translation done manually (no LLM was used).
|
|
||
| `/buy 1000 50000 IRT "پرداخت با عابربانک"` | ||
| `/sell 1000 300000 IRT "کارت به کارت"` |
Catrya
left a comment
Catrya
left a comment
There was a problem hiding this comment.
Hi @RamzArzFarsi , it won't compile; there are errors with the location keys. This is what appears when trying to compile:
[2025-12-15T16:52:25.134-06:00] error: Unhandled Rejection: YAMLException: can not read a block mapping entry; a multiline key may not be an implicit key (10:62)
7 | ...
8 | ... های پایاپای بیتکوین روی شبکه لایتنینگ کمک میکند.
9 | ...
10 | ... د از دستورهای زیر استفاده کنید:
-----------------------------------------^
11 | ...
12 | ... ستورهای /buy (خرید) یا /sell (فروش) منتشر کنید و از دستورالعم ...
The compiling error should be gone now. Please try again and let me know if there are any more errors. |
Luquitasjeffrey
left a comment
Luquitasjeffrey
left a comment
There was a problem hiding this comment.
Hi @RamzArzFarsi, I pulled your pr on my local and I'm still getting the same error:
[2025-12-17T18:40:51.873-03:00] error: Unhandled Rejection: YAMLException: can not read a block mapping entry; a multiline key may not be an implicit key (10:64)
7 | ...
8 | ... های پایاپای بیتکوین روی شبکه لایتنینگ کمک میکند.
9 | ...
10 | ... د از دستورهای زیر استفاده کنید:
-----------------------------------------^
11 | ...
12 | ... ستورهای /buy (خرید) یا /sell (فروش) منتشر کنید و از دستورالعم ...
Please fix your syntax in the fa.yaml file so we can proceed with your pr.
Thanks
Catrya
left a comment
Catrya
left a comment
There was a problem hiding this comment.
As @Luquitasjeffrey said, it still doesn't work
The bot compiles but crashes on startup due to YAML syntax errors in fa.yaml. The translation file has invalid formatting that prevents the bot from starting. This needs to be fixed.
Luquitasjeffrey
left a comment
Luquitasjeffrey
left a comment
There was a problem hiding this comment.
Now your pr is Ok. It can be merged to the main branch
|
Please merge the PR if no further action is needed from my side. |
|
@RamzArzFarsi can you please edit PR title and description to have something that makes sense there? |
RamzArzFarsi
changed the title
|
The PR is renamed. |
|
Please replace the "Summary by CodeRabbit" with something that actually applies. |
|
@aarani can you review? |
|
Hi @RamzArzFarsi. Please solve your conflicts with the main branch so we can proceed reviewing and merging this pr |
Luquitasjeffrey
left a comment
Luquitasjeffrey
left a comment
There was a problem hiding this comment.
Please fix your conflicts with main so we can proceed merging your pr
|
@RamzArzFarsi can you please fix the conflicts and rebase? |
|
I apologise for the delay. The recent events in Iran suddenly made me extremely busy. Thank you for your patience and understanding. |
![mostronatorcoder[bot]](https://avatars.githubusercontent.com/in/2922838?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review ✅
Good work on this PR. I verified the following:
en.yaml fixes (3 corrections) ✅
- Step 7:
/release→/fiatsentfor the buyer flow — correct, buyers use/fiatsentafter paying fiat, not/release - sell_correct_format: "fiat amount" → "sats amount" — correct, the
0parameter indicates sats amount (letting the bot calculate price from market rate) - image_processing_error: "wait few minutes" → "wait a few minutes" — grammar fix
fa.yaml (Persian translation) ✅
- YAML syntax is valid — the parsing error reported earlier has been fixed
- 279 of 280 keys present — only
counterparty_wants_cooperativecancelis missing (was added to main after this PR was created, can be addressed in a follow-up) - Conflicts with main resolved — merge commit on Feb 4
- Translation appears to be a thorough manual rewrite (not LLM-generated) with more natural Persian phrasing
- Examples updated with more realistic IRT values (300,000 instead of 50,000)
/fiatsentcorrection carried through consistently to the Persian translation as well
Minor note
- Missing key
counterparty_wants_cooperativecancelin fa.yaml — this was added to main after the PR was created. Should be added in a follow-up PR or the contributor can add it before merge.
Approved — the English fixes are correct and important, and the Persian translation is a significant quality improvement.
5 participants
The Persian translation file has weird phrasings and feels like a draft LLM translation.
This PR aims to replace it with a more refined and natural-sounding Persian translation done manually (no LLM is used).
Additionally, three minor mistakes were found in the English file along the way, which are also corrected by this PR.
Summary by CodeRabbit
/fiatsentcommand after Fiat payment and added seller-confirmation step before satoshis are sent.