Skip to content

fix: pin ssm-simulators dependency to version 0.12.0#901

Open
cpaniaguam wants to merge 7 commits intomainfrom
use-0.12.0b1
Open

fix: pin ssm-simulators dependency to version 0.12.0#901
cpaniaguam wants to merge 7 commits intomainfrom
use-0.12.0b1

Conversation

@cpaniaguam
Copy link
Collaborator

No description provided.

@AlexanderFengler
Copy link
Member

Approved corresponding change on ssm-simulators side @cpaniaguam .

@cpaniaguam
Copy link
Collaborator Author

@AlexanderFengler As you can see hssm builds with the changes introduced in https://github.com/lnccbrown/ssm-simulators/pull/258/changes but I see Hayden merged lnccbrown/ssm-simulators#246. Should the ssm-simulators release include Hayden's changes?

@AlexanderFengler
Copy link
Member

@cpaniaguam working on a larger PR for ssm-simulators, that I think at this point we can just include. Trying to have it finalized by tn.

@AlexanderFengler
Copy link
Member

@cpaniaguam this should be unblocked.

@cpaniaguam cpaniaguam changed the title fix: pin ssm-simulators dependency to version 0.12.0b1 fix: pin ssm-simulators dependency to version 0.12.0 Mar 3, 2026
@cpaniaguam
Copy link
Collaborator Author

@cpaniaguam this should be unblocked.

We need the v0.12.0 release for ssms.

@AlexanderFengler
Copy link
Member

@cpaniaguam am I blocked that one rn?

@cpaniaguam
Copy link
Collaborator Author

@cpaniaguam this should be unblocked.

The goal of this PR was to check HSSM worked with the lastest changes in ssms. We need the release ssms

@cpaniaguam am I blocked that one rn?

We need to decide what commits to include in the release. Should we do the current state of main? @AlexanderFengler

@AlexanderFengler
Copy link
Member

@cpaniaguam let's get

#900 ( @krishnbera )
#903
#905
#909
#911
#914

merged and then do the release?

Then the next bigger release will have rlssm and the class refactors.
I'll make sure to review what I need to review by tomorrow afternoon.

@digicosmos86
Copy link
Collaborator

@cpaniaguam let's get

#900 ( @krishnbera ) #903 #905 #909 #911 #914

merged and then do the release?

Then the next bigger release will have rlssm and the class refactors. I'll make sure to review what I need to review by tomorrow afternoon.

Note: the choice-only PRs are not complete yet. I want to get other PRs merged before the remaining one to avoid merge conflicts

@AlexanderFengler
Copy link
Member

@cpaniaguam let's get
#900 ( @krishnbera ) #903 #905 #909 #911 #914
merged and then do the release?
Then the next bigger release will have rlssm and the class refactors. I'll make sure to review what I need to review by tomorrow afternoon.

Note: the choice-only PRs are not complete yet. I want to get other PRs merged before the remaining one to avoid merge conflicts

Can you help me understand what you mean here? There are other un-opened PRs that your still want to add? @digicosmos86

@digicosmos86
Copy link
Collaborator

@cpaniaguam let's get
#900 ( @krishnbera ) #903 #905 #909 #911 #914
merged and then do the release?
Then the next bigger release will have rlssm and the class refactors. I'll make sure to review what I need to review by tomorrow afternoon.

Note: the choice-only PRs are not complete yet. I want to get other PRs merged before the remaining one to avoid merge conflicts

Can you help me understand what you mean here? There are other un-opened PRs that your still want to add? @digicosmos86

Correct. This one changes the HSSM class so I didn't want to add it with other outstanding PRs. Might just be too much merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants