fix: pin ssm-simulators dependency to version 0.12.0#901
fix: pin ssm-simulators dependency to version 0.12.0#901cpaniaguam wants to merge 7 commits intomainfrom
Conversation
|
Approved corresponding change on ssm-simulators side @cpaniaguam . |
|
@AlexanderFengler As you can see hssm builds with the changes introduced in https://github.com/lnccbrown/ssm-simulators/pull/258/changes but I see Hayden merged lnccbrown/ssm-simulators#246. Should the ssm-simulators release include Hayden's changes? |
|
@cpaniaguam working on a larger PR for ssm-simulators, that I think at this point we can just include. Trying to have it finalized by tn. |
|
@cpaniaguam this should be unblocked. |
We need the v0.12.0 release for ssms. |
|
@cpaniaguam am I blocked that one rn? |
The goal of this PR was to check HSSM worked with the lastest changes in ssms. We need the release ssms
We need to decide what commits to include in the release. Should we do the current state of |
|
@cpaniaguam let's get #900 ( @krishnbera ) merged and then do the release? Then the next bigger release will have rlssm and the class refactors. |
Note: the choice-only PRs are not complete yet. I want to get other PRs merged before the remaining one to avoid merge conflicts |
Can you help me understand what you mean here? There are other un-opened PRs that your still want to add? @digicosmos86 |
Correct. This one changes the HSSM class so I didn't want to add it with other outstanding PRs. Might just be too much merge conflicts |
No description provided.