Skip to content

fix: update charge before sending webhook #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dni merged 1 commit into from
Jun 5, 2026
Merged

fix: update charge before sending webhook #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,12 @@ async def on_invoice_paid(payment: Payment) -> None:
charge.paid = True
logger.success(f"Charge {charge.id} invoice paid.")
charge.add_extra({"payment_method": "lightning"})
charge = await update_charge(charge)
await send_success_websocket(charge)
if charge.webhook:
resp = await call_webhook(charge)
charge.add_extra(resp)
await update_charge(charge)
await update_charge(charge)


def start_onchain_listener(address: str):
Expand Down Expand Up @@ -124,12 +125,13 @@ async def _handle_ws_message(address: str, data: dict):
charge.balance = confirmed_balance
charge.pending = unconfirmed_balance
charge.paid = charge.balance >= charge.amount
await send_success_websocket(charge)
if charge.paid:
charge.add_extra({"payment_method": "onchain"})
logger.success(f"Charge {charge.id} onchain paid.")
stop_onchain_listener(address)
charge = await update_charge(charge)
await send_success_websocket(charge)
if charge.webhook:
resp = await call_webhook(charge)
charge.add_extra(resp)
await update_charge(charge)
await update_charge(charge)
4 changes: 4 additions & 0 deletions views_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,12 @@ async def api_charge_webhook(charge_id: str) -> Charge:
raise HTTPException(
status_code=HTTPStatus.BAD_REQUEST, detail="No webhook set."
)
# update payment status
charge = await update_charge(charge)

resp = await call_webhook(charge)
charge.add_extra(resp)
# update webhook status
charge = await update_charge(charge)
return charge

Expand Down
Loading