Skip to content

fix: gracefully handle Lnurl errors on api #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dni merged 3 commits into from
Jan 15, 2026
Merged

fix: gracefully handle Lnurl errors on api #123

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5784d08
fix: gracefully handle InvalidLnurl error on api
dni Jan 15, 2026
0904766
fixup!
dni Jan 15, 2026
de8ef71
fixup!
dni Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions views_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
require_admin_key,
require_invoice_key,
)
from lnurl import InvalidUrl

from .crud import (
create_pay_link,
Expand All @@ -28,6 +29,24 @@
lnurlp_api_router = APIRouter()


def check_lnurl_encode(req: Request, link_id: str) -> str:
try:
return lnurl_encode_link_id(req, link_id)
except InvalidUrl as exc:
raise HTTPException(
detail=(
f"Invalid URL for LNURL encoding: `{req.base_url}`. "
"Check proxy settings."
),
status_code=HTTPStatus.INTERNAL_SERVER_ERROR,
) from exc
except Exception as exc:
raise HTTPException(
detail="Error encoding LNURL.",
status_code=HTTPStatus.INTERNAL_SERVER_ERROR,
) from exc


@lnurlp_api_router.get("/api/v1/links", status_code=HTTPStatus.OK)
async def api_links(
req: Request,
Expand All @@ -41,7 +60,7 @@ async def api_links(

links = await get_pay_links(wallet_ids)
for link in links:
link.lnurl = lnurl_encode_link_id(req=req, link_id=link.id)
link.lnurl = check_lnurl_encode(req=req, link_id=link.id)
return links


Expand All @@ -66,7 +85,7 @@ async def api_link_retrieve(
detail="Not your pay link.", status_code=HTTPStatus.FORBIDDEN
)

link.lnurl = lnurl_encode_link_id(req, link.id)
link.lnurl = check_lnurl_encode(req, link.id)
return link


Expand Down Expand Up @@ -178,7 +197,8 @@ async def api_link_create_or_update(

link = await create_pay_link(data)

link.lnurl = lnurl_encode_link_id(req, link.id)
link.lnurl = check_lnurl_encode(req=req, link_id=link.id)

return link


Expand Down