WIP: Room / building synonyms integration (#21)#24
Open
Gustl22 wants to merge 1 commit intolmu-navigator:masterfrom
Open
WIP: Room / building synonyms integration (#21)#24Gustl22 wants to merge 1 commit intolmu-navigator:masterfrom
Gustl22 wants to merge 1 commit intolmu-navigator:masterfrom
Conversation
Author
|
@dmo60 @MaxMediaPictures any opinions on that? |
Member
|
Hey @Gustl22! Thanks a lot for the contributions! Sorry for the late response. There is no development happening on the app since quite some time and I missed the PRs you created. Please bare with me, I don't have a lot of capacity right now for this project. But as soon as I find some time in the upcoming weeks, I will checkout and review your changes. 👍 Feel free to remind me every now and then if I don't come back to you. Thank you for your patience! |
Author
|
@dmo60 No hurry, only wanted to check your capacities. May only a quick review, if can further improve or should extend to collaborative system and give hints how to achieve that (like mentioned in #21 by @FloEdelmann) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #21,
Features:
I know that users cannot tag their own buildings / rooms, but if wanted, the json can be extended via new issues or own PRs. Also the data has to be transfered to the web / ios version (via db).
Drawbacks:
Apparently not all the naming data is provided, so help from other students is appreciated.
Of course this is much in one PR, so can split them in separate commits / PRs.
Please give me feedback. Thx.