Skip to content

fix: check partial stop on cumulative sglang output #3891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: check partial stop on cumulative sglang output #3891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fastchat/serve/sglang_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,13 +140,13 @@ async def generate_stream(self, params):
async for out, meta_info in state.text_async_iter(
var_name="response", return_meta_data=True
):
partial_stop = any(is_partial_stop(out, i) for i in stop)
entire_output += out
partial_stop = any(is_partial_stop(entire_output, i) for i in stop)

# prevent yielding partial stop sequence
if partial_stop:
continue

entire_output += out
prompt_tokens = meta_info["prompt_tokens"]
completion_tokens = meta_info["completion_tokens"]

Expand Down
Loading