changed the formatting of monitor.py#3592
Open
yixin-huang1 wants to merge 6 commits intolm-sys:mainfrom
Open
Conversation
Collaborator
CodingWithTim
left a comment
CodingWithTim
left a comment
There was a problem hiding this comment.
@yixin-huang1 Overall, it looks very good. The code is clean and easy to read. Thanks a lot for doing this!
infwinston
reviewed
Oct 20, 2024
Collaborator
infwinston
left a comment
infwinston
left a comment
There was a problem hiding this comment.
left some comments, thanks @yixin-huang1 !
| ) | ||
| dataFrame["CI"] = dataFrame.CI.map(ast.literal_eval) | ||
| dataFrame["CI"] = dataFrame.CI.map(lambda x: f"+{x[1]}/-{x[0]}") | ||
| dataFrame["CI"] = dataFrame.CI.map(lambda x: f"+{x[1]}/{x[0]}") |
Collaborator
There was a problem hiding this comment.
why do we remove - here?
Author
There was a problem hiding this comment.
there was an extra "-" displayed so something like "--3.2".
infwinston
reviewed
Oct 20, 2024
| ) | ||
| dataFrame["CI"] = dataFrame.CI.map(ast.literal_eval) | ||
| dataFrame["CI"] = dataFrame.CI.map(lambda x: f"+{x[1]}/-{x[0]}") | ||
| dataFrame["CI"] = dataFrame.CI.map(lambda x: f"+{x[1]}/{x[0]}") |
Collaborator
|
@yixin-huang1 @infwinston What is the status? Is this good to ship? |
Author
As far I can recall it is good to be shipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding a new style column for the webpage of arena hard leaderboard @infwinston @CodingWithTim