Skip to content

Conversation

@waldyrious
Copy link

It's not strictly required, but it's useful metadata, and part of the recommended license template text (see http://choosealicense.com/licenses/isc/ and https://opensource.org/licenses/isc-license)

It's not strictly required, but it's useful metadata, and part of the recommended license template text (see http://choosealicense.com/licenses/isc/ and https://opensource.org/licenses/isc-license)
@kylef
Copy link

kylef commented Sep 6, 2018

@lloyd also package.json declares the license as MIT which isn't what the package is licensed (ISC):

"licenses": {
    "type": "MIT",
    "url": "https://raw.github.com/lloyd/JSONSelect/master/LICENSE"
}

This should become "licenses": "ISC" if updated, because the format of package.json deprecates the old object syntax in favour of SPDX identifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants