Some Python polishing for ElementTree, parenthesis and dummy#26
Open
alberto743 wants to merge 3 commits intollnl:trainingfrom
Open
Some Python polishing for ElementTree, parenthesis and dummy#26alberto743 wants to merge 3 commits intollnl:trainingfrom
alberto743 wants to merge 3 commits intollnl:trainingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit applies ElementTree in a consistent way, since cElementTree is deprecated.
The second commit fixes a potential issue with parenthesis.
The third commit replaces
dummywith_following the Python standard: this should provide better reading and potentially avoiding variable management on function returns.Feel free to cherry pick as you like.
Are there CI/CD tests to verify if everything is fine?