Open
Conversation
Collaborator
|
I think all of these fixes have either been included in master or fixed another way. For example we're now using raw strings for most docstrings instead of double-escaping LaTeX stuff. The main functional difference with master is the covariance file naming convention in brownies/bin/endf2gnds.py: gnds-covar.xml (master) vs. gndsCov.xml (this branch). I prefer not to change that convention. If scripts need to load covariance data, the best option is to use ReactionSuite.loadCovariances() |
Collaborator
|
I'd like to close this MR unless you object. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection of changes that may already be in a development branch, but here are the fixes identified by Dave