Conversation
pearce8
previously approved these changes
Jan 17, 2026
Collaborator
Author
|
from Strongexec_mode=test exec_mode=perf Weakperf Throughputperf |
| self.add_experiment_variable("arch", "OpenMP") | ||
| if self.spec.satisfies("exec_mode=test"): | ||
| self.add_experiment_variable( | ||
| "total_problem_size_dict", {"lx": 32, "ly": 6, "lz": 4, "lt": 3}, True |
Collaborator
There was a problem hiding this comment.
lx, ly, lz, and lt are local problem sizes.
| self.add_experiment_variable("n_nodes", ["1"], True) | ||
| # Per-process size (in zones) in each dimension | ||
| self.add_experiment_variable( | ||
| "total_problem_size_dict", {"lx": 64, "ly": 12, "lz": 8, "lt": 3}, True |
Collaborator
There was a problem hiding this comment.
Here is also local, so total -> local is better
| process_problem_size="{lx}*{ly}*{lz}/{n_ranks}", | ||
| total_problem_size="{lx}*{ly}*{lz}", | ||
| n_resources="{px}*{py}*{pz}*{pt}", | ||
| process_problem_size="({lx}*{ly}*{lz}*{lt})/({px}*{py}*{pz}*{pt})", |
Collaborator
There was a problem hiding this comment.
process_problem_size="{lx}*{ly}*{lz}*{lt}",
| total_problem_size="{lx}*{ly}*{lz}", | ||
| n_resources="{px}*{py}*{pz}*{pt}", | ||
| process_problem_size="({lx}*{ly}*{lz}*{lt})/({px}*{py}*{pz}*{pt})", | ||
| total_problem_size="{lx}*{ly}*{lz}*{lt}", |
Collaborator
There was a problem hiding this comment.
total_problem_size="{lx}*{ly}*{lz}*{lt}*{px}*{py}*{pz}*{pt}",
Collaborator
|
Added a comment to clarify a misunderstanding about the QWS |
pearce8
previously approved these changes
Jan 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1192 +/- ##
===========================================
+ Coverage 62.97% 63.09% +0.11%
===========================================
Files 45 45
Lines 3433 3433
Branches 264 264
===========================================
+ Hits 2162 2166 +4
+ Misses 1262 1258 -4
Partials 9 9 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description