Skip to content

Miscelaneous changes from MeshClipper development#1799

Merged
gunney1 merged 4 commits intodevelopfrom
feature/gunney/mesh-clipper-misc
Feb 20, 2026
Merged

Miscelaneous changes from MeshClipper development#1799
gunney1 merged 4 commits intodevelopfrom
feature/gunney/mesh-clipper-misc

Conversation

@gunney1
Copy link
Copy Markdown
Contributor

@gunney1 gunney1 commented Feb 12, 2026

Summary

These are some small changes that didn't fit anywhere when I was breaking the big MeshClipper code review into small pieces.

  1. Preserve the allocator id user had set on an output Array. MeshClipping code should respect what allocators the users want to use.
  2. Robustly handle conflict between blueprint and mint over whether a "fields" node is required when there's no field stored.
  3. Clarify that some input data should be in host memory.

We have conflicting requirements between blueprint and mint
regargind an empty field node.  This change lets the MeshClipper
work regardless of whether the empty field node is there.
@gunney1 gunney1 self-assigned this Feb 12, 2026
@gunney1 gunney1 marked this pull request as ready for review February 12, 2026 14:46
@gunney1 gunney1 added the Quest Issues related to Axom's 'quest' component label Feb 12, 2026
Copy link
Copy Markdown
Contributor

@Arlie-Capps Arlie-Capps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these fixes, @gunney1 .

@Arlie-Capps
Copy link
Copy Markdown
Contributor

Brian, why isn't develop the target for this MR?

@gunney1
Copy link
Copy Markdown
Contributor Author

gunney1 commented Feb 13, 2026

Brian, why isn't develop the target for this MR?

Just following the pattern that worked well when I was splitting up the mesh clipping work. I guess it could work just as well to merge into develop, but I think there's some dependencies that might bring in un-related changes.

@Arlie-Capps
Copy link
Copy Markdown
Contributor

Brian, why isn't develop the target for this MR?

Just following the pattern that worked well when I was splitting up the mesh clipping work. I guess it could work just as well to merge into develop, but I think there's some dependencies that might bring in un-related changes.

I see: thank you for the explanation. I'm interested in reviewing changes once only, which is why I would prefer targeting develop. If others on the team have opinions on this, I'd be interested to read them.

@gunney1
Copy link
Copy Markdown
Contributor Author

gunney1 commented Feb 13, 2026

Brian, why isn't develop the target for this MR?

Just following the pattern that worked well when I was splitting up the mesh clipping work. I guess it could work just as well to merge into develop, but I think there's some dependencies that might bring in un-related changes.

I see: thank you for the explanation. I'm interested in reviewing changes once only, which is why I would prefer targeting develop. If others on the team have opinions on this, I'd be interested to read them.

I think you would not have to review the same code twice this way, unless the review required some radical changes. I don't think that will be the case here. When we have change B dependent on change A, we probably don't want to set both of them to merge into develop, because B's changes must also include A's, and you'd see A's changes twice.

Base automatically changed from feature/gunney/clipper-strategy-util to develop February 20, 2026 05:39
@gunney1 gunney1 merged commit e08e6f0 into develop Feb 20, 2026
15 checks passed
@gunney1 gunney1 deleted the feature/gunney/mesh-clipper-misc branch February 20, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Quest Issues related to Axom's 'quest' component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants