Fixes for spindle's internal path parsing#148
Open
mplegendre wants to merge 2 commits intollnl:develfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two bugs, both related to the spindle server's path parsing:
First, files in the root filesystem were being mis-parsed by internal spindle path parsing. Something like "/bin" would get parsed into a file and directory component, and we were incorrectly making the directory the empty string in this case. That would fool other parts of spindle into thinking it was a relative path, and thus "/bin" would get cached by spindle as "${PWD}/bin".
While fixing that I added additional tests around path parsing and discovered more issues around symlinks and paths that use "..". In short, we were resolving the ".." in those paths before resolving symlinks. That's not wise, as a ".." in a path moves up a directory from a symlink target, not source.
I significantly rewrote path parsing for a couple places in spindle where this matters, and added new tests.