In-memory Finch-ExaCA coupling with multiple Finch simulations#398
Open
MattRolchigo wants to merge 6 commits intollnl:masterfrom
Open
In-memory Finch-ExaCA coupling with multiple Finch simulations#398MattRolchigo wants to merge 6 commits intollnl:masterfrom
MattRolchigo wants to merge 6 commits intollnl:masterfrom
Conversation
MattRolchigo
force-pushed
the
unique_layers_finch
branch
from
f018e09 to
2e72701
Compare
MattRolchigo
force-pushed
the
unique_layers_finch
branch
from
a5612d4 to
b3d1c16
Compare
Collaborator
|
Blocked by ORNL-MDF/Finch#28 |
streeve
reviewed
Feb 18, 2026
MattRolchigo
force-pushed
the
unique_layers_finch
branch
from
fcada6d to
b858ebe
Compare
streeve
reviewed
Apr 16, 2026
Collaborator
Author
There was a problem hiding this comment.
It should work either way due to the backwards compatibility (the fact that the test passed is a good sign), but yes I should change this to account for the preferred method of supplying Finch-ExaCA input files (1 combined input file instead of two)
| The .json files in the examples subdirectory are provided on the command line to let ExaCA know which problem is being simulated. The json files contain different input sections, with certain inputs only used for certain problem types. For optional inputs, the default value used is noted. There are two types of input files for ExaCA: "singular" (ExaCA) input files and "combined" (Finch-ExaCA). For combined input files, the top level input sections are `Finch` and `ExaCA`, with subsections `SimulationType`, `MaterialFileName`, `GrainOrientationsFile`, `RandomSeed`, `Domain`, `Nucleation`, `TemperatureData`, `Substrate`, and `Printing` in the ExaCA portion of the file and subsections as given in the Finch README for the Finch portion of the file. Note that for the Finch section of these files, inputs that vary on different layers (for multilayer simulations) can be given in a `layers` list; see `examples/Inp_FinchVariedLayers.json` for an example of this. For singular input files, the aforemenioned ExaCA subsections are top level inputs. | ||
|
|
||
| ## Top level inputs | ||
| ## Top level inputs (for singular type input files) or second level inputs (for combined input files) |
Collaborator
There was a problem hiding this comment.
Suggested change
| ## Top level inputs (for singular type input files) or second level inputs (for combined input files) | |
| ## Top level inputs (individual input files) or ExaCA level inputs (combined input files) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged concurrently with corresponding pull request in the Finch repository