fix: remove unnecessary slice for message history #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using this library, i notice that the LLM sometime answer to the previous message although it have been answered before. After debugging, i found out that the last message from the LLM before the new query is deleted, and after looking through the code, before sending the conversation history to the LLM, it call slice method to remove the last item on the history, and it remove the LLM last message.
This was discovered independently and doesn't relate to any opened issues.
Type of change
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
I simply log the messages on the
preparemethod of theBaseModelclass before returning, and do a simple query with this code.Checklist: