Skip to content

Zero trimmed ranges under verifier flags to make Trim() observable #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
llersch wants to merge 1 commit into from
Closed

Zero trimmed ranges under verifier flags to make Trim() observable #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/common/local_file_system.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,19 +571,24 @@ int64_t LocalFileSystem::Write(FileHandle &handle, void *buffer, int64_t nr_byte
}

bool LocalFileSystem::Trim(FileHandle &handle, idx_t offset_bytes, idx_t length_bytes) {
bool trimmed = false;
#if defined(DUCKDB_RUN_SLOW_VERIFIERS) || defined(DUCKDB_ALTERNATIVE_VERIFY)
std::vector<char> zeros(length_bytes, '\0');
Write(handle, zeros.data(), length_bytes, offset_bytes);
trimmed = true;
#endif
#if defined(__linux__)
// FALLOC_FL_PUNCH_HOLE requires glibc 2.18 or up
#if __GLIBC__ < 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ < 18)
return false;
// Nothing
#else
int fd = handle.Cast<UnixFileHandle>().fd;
int res = fallocate(fd, FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE, UnsafeNumericCast<int64_t>(offset_bytes),
UnsafeNumericCast<int64_t>(length_bytes));
return res == 0;
trimmed = (res == 0);
#endif
#else
return false;
#endif
return trimmed;
}

int64_t LocalFileSystem::GetFileSize(FileHandle &handle) {
Expand Down
Loading